Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart improvements #37

Merged
merged 1 commit into from
May 31, 2023
Merged

Helm chart improvements #37

merged 1 commit into from
May 31, 2023

Conversation

inteon
Copy link
Member

@inteon inteon commented May 8, 2023

  • remove deprecated storage.k8s.io/v1beta1
  • add namespace values that make sure namespace is included when running helm template
  • use dynamic $(POD_NAMESPACE) instead of static templated {{ .Release.Namespace }} value (should resolve to same value)

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 8, 2023
@inteon inteon force-pushed the helm_chart branch 2 times, most recently from 1726d5b to ef1e2f8 Compare May 8, 2023 15:36
@irbekrm
Copy link
Contributor

irbekrm commented May 24, 2023

The PR looks good to me, except for I'd like to understand the effect of this change if a user upgrades the csi-driver-spiffe to this version and already has some csi-driver-spiffe volumes

Signed-off-by: Tim Ramlot <[email protected]>
@inteon
Copy link
Member Author

inteon commented May 30, 2023

The PR looks good to me, except for I'd like to understand the effect of this change if a user upgrades the csi-driver-spiffe to this version and already has some csi-driver-spiffe volumes

I removed that change, so we can easily merge this PR. The issue is now tracked here: #41

Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

Looks good! Nothing here to block merging, but adding a hold for my question. Feel free to unhold!

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2023
@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@inteon
Copy link
Member Author

inteon commented May 31, 2023

/unhold

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2023
@jetstack-bot jetstack-bot merged commit 8f5a210 into main May 31, 2023
@inteon inteon deleted the helm_chart branch February 19, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants