-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm chart improvements #37
Conversation
1726d5b
to
ef1e2f8
Compare
The PR looks good to me, except for I'd like to understand the effect of this change if a user upgrades the csi-driver-spiffe to this version and already has some csi-driver-spiffe volumes |
Signed-off-by: Tim Ramlot <[email protected]>
I removed that change, so we can easily merge this PR. The issue is now tracked here: #41 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
Looks good! Nothing here to block merging, but adding a hold for my question. Feel free to unhold!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
storage.k8s.io/v1beta1
helm template
$(POD_NAMESPACE)
instead of static templated{{ .Release.Namespace }}
value (should resolve to same value)