Don't include wrong usages in e2e CSR blob #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
dco-signoff: yes
Signed-off-by: Tim Ramlot <[email protected]>
inteon
force-pushed
the
fix_e2e_tests
branch
from
887f079 to
3995853
Compare
jetstack-bot
added
size/S
inteon
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our cert-manager webhook has become a bit more strict, we improved the logic that detects mismatches between the usages in the CSR blob and the usages in the CertificateRequest resource. If the usages extension is included in the CSR blob, we expect it to match the usages specified in the CertificateRequest resource.
This e2e test was generating a CSR blob with different usages than specified in the CertificateRequest resource.
It used a Certificate resource that does not have the usages set to generate the CSR blob.
This means that the usages in the CSR blob defaulted to [ 'digital signature', 'key encipherment' ].
The test did also set the usages in the CertificateRequest, but it specified different values there.
see https://storage.googleapis.com/jetstack-logs/pr-logs/pull/cert-manager_csi-driver-spiffe/46/pull-cert-manager-csi-driver-spiffe-e2e/1725084507725369344/build-log.txt