Migrate to ginkgo v2 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
dco-signoff: yes
inteon
force-pushed
the
ginkgo_v2
branch
2 times, most recently
from
abd3974 to
a7fa2ee
Compare
Signed-off-by: Tim Ramlot <[email protected]>
SgtCoDFish
approved these changes
Jan 9, 2024
| @@ -103,7 +103,7 @@ $(BINDIR) $(BINDIR)/chart: | |||
| mkdir -p $@ | |||
|
|
|||
| $(BINDIR)/ginkgo: | |||
| GOBIN=$(BINDIR) go install github.com/onsi/ginkgo/ginkgo | |||
| GOBIN=$(BINDIR) go install github.com/onsi/ginkgo/v2/ginkgo | |||
There was a problem hiding this comment.
comment: it hurts my soul to see this Makefile, there are so many things wrong with it 😂 Obviously not a blocker for this PR, but my god...
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not setup the junit reporting yet, this will be re-added once we migrate to the makefile-modules.