Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move repo for cert-manager-webhook-example #440

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Move repo for cert-manager-webhook-example #440

merged 2 commits into from
Feb 23, 2021

Conversation

jakexks
Copy link
Member

@jakexks jakexks commented Feb 23, 2021

@jetstack-bot
Copy link
Contributor

@jakexks: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 23, 2021
@jetstack-bot jetstack-bot added the area/cert-manager Indicates a PR related to cert-manager label Feb 23, 2021
@jakexks jakexks removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 23, 2021
@jetstack-bot jetstack-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 23, 2021
@JoshVanL
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2021
@JoshVanL
Copy link
Contributor

/hold

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2021
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2021
@jakexks
Copy link
Member Author

jakexks commented Feb 23, 2021

/hold cancel

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2021
@jakexks jakexks requested review from munnerz and JoshVanL February 23, 2021 17:52
@JoshVanL
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakexks, simplyzee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2021
@jetstack-bot jetstack-bot merged commit 365f052 into cert-manager:master Feb 23, 2021
@jetstack-bot
Copy link
Contributor

@jakexks: Updated the following 2 configmaps:

  • job-config configmap in namespace default at cluster default using the following files:
    • key cert-manager-webhook-example-presubmits.yaml using file ``
    • key cert-manager-webhook-example-presubmits.yaml using file config/jobs/cert-manager/webhook-example/cert-manager-webhook-example-presubmits.yaml
  • config configmap in namespace default at cluster default using the following files:
    • key config.yaml using file config/config.yaml

In response to this:

For context: cert-manager/webhook-example#23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakexks jakexks deleted the move-cert-manager-webhook-example branch February 24, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simplyzee simplyzee simplyzee approved these changes

@maelvls maelvls Awaiting requested review from maelvls

@munnerz munnerz Awaiting requested review from munnerz

@JoshVanL JoshVanL Awaiting requested review from JoshVanL

Assignees

@JoshVanL JoshVanL

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cert-manager Indicates a PR related to cert-manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakexks @jetstack-bot @JoshVanL @munnerz @simplyzee