Prompt the user to insert their U2F Device #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Having the script raise a RuntimeWarning and exit is a real usability issue and I'd love to see this land. We know coverage is low in the project overall; should coveralls block this merge? |
|
FWIW, I would love to see #38 land first, and then I'll rebase this. It's no major change but it would cause conflicts. |
|
Agree, we are so close on #38, let's do that then clean up some of these other smaller enhancements. |
|
Replaced by #44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior of this tool will cause an error (and exit) if the user doesn't have their U2F key inserted. It's a little more user-friendly if we prompt them to insert and allow for a couple of retries. This PR adds that.