Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Migrate to SeleniumHQ 3 #11

Closed
cezarypiatek opened this issue Feb 5, 2017 · 6 comments
Closed

Migrate to SeleniumHQ 3 #11

cezarypiatek opened this issue Feb 5, 2017 · 6 comments

Comments

@cezarypiatek
Copy link
Owner

cezarypiatek commented Feb 5, 2017

  1. Update nuget package to Selenium 3
  2. Update script for downloading webdrivers (add geckodriver)
@kmorcinek
Copy link

ad 1. I can update them. When will I be sure that everything works? When the code compiles and the SampleUITest tests are passing?

ad 2. Should it be done similar to #20 ?

@kmorcinek
Copy link

I have created a bug #21 that covers updating to geckodriver. The are separate think (geckodriver and Selenium 3), so separate issues are better, @cezarypiatek what do you think?

@cezarypiatek
Copy link
Owner Author

cezarypiatek commented Mar 25, 2017

Ad1. I have a private set of tests (over a 300 assertions) When I run this suit and everything will be ok then I'll accept your PR.

Ad2. Please extend script for downloading drivers. Nuget packages should be an alternative (there is no OFFICIAL nuget package with given driver)

cezarypiatek added a commit that referenced this issue Apr 24, 2017
- Update selenium to 3.4
- Update drivers
- Fix filtering covered endpoints
cezarypiatek added a commit that referenced this issue Apr 24, 2017
- Add geckodriver
cezarypiatek added a commit that referenced this issue Apr 24, 2017
- Fix selenium version in nuspect
cezarypiatek added a commit that referenced this issue Apr 24, 2017
- Add scrollIntoView method
cezarypiatek added a commit that referenced this issue Apr 24, 2017
- Add ScrollIntoViewIfNotVisible
@cezarypiatek
Copy link
Owner Author

According do geckodriver issue tracker (https://github.com/mozilla/geckodriver/issues) there is a lot issues related to clicking and typing (SenKeys) so I'm still not convinced about migration to Selenium 3.X

@kmorcinek
Copy link

I fully understand that.

cezarypiatek added a commit that referenced this issue Oct 10, 2017
- Update selenium version
- Introduce geckodiver BrowserType
cezarypiatek added a commit that referenced this issue Oct 10, 2017
- remove reference to driver binary
@cezarypiatek
Copy link
Owner Author

I've created branch SeleniumHQ_3_5 with Selenium 3.6. There has been introduced two BrowserTypes related to Firefox:

  1. BrowserType.Firefox -> Use legacy Firefox Driver for Firefox 47.0.1
  2. BrowserType.FirefoxGecko -> Use Geckodriver (marionette)

This is necessary because Geckodriver has issues with clicking what makes impossible to create stable UI tests. It also does not support full page screenshots what makes VisualAssertion useless.

cezarypiatek added a commit that referenced this issue Oct 17, 2017
- Update selenium version
- Introduce geckodiver BrowserType
cezarypiatek added a commit that referenced this issue Oct 17, 2017
- remove reference to driver binary
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants