Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training #578

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Training #578

merged 4 commits into from
Jan 2, 2025

Conversation

lhmarsden
Copy link

I have added links to some of my training materials to the training page. Let me know what you think!

This was discussed in #539

@lhmarsden
Copy link
Author

I notice that I have been clumsy here and included the commits from other pull requests here too, so I will close the other pull requests:

Including a link to the Nansen Legacy template generator:
#577

AGU prize:
#576
Which address this issue:
#551

@erget
Copy link
Member

erget commented Jan 2, 2025

Thanks @lhmarsden - I love this, especially the fact that from here on out we can put flash messages up very easily!

I actually quite liked having multiple PRs devoted to different topics but will merge this now. If I were doing it and had my handy command line to hand, I would have proceeded somewhat as follows (not so easy with the setup I have in Windows) if I'd put them all in the same PR by accident:

  1. Make a new branch from main
  2. Cherrypick topic x onto that branch
  3. Push as new branch to repo, make pull request for x
  4. Repeat for all topics

Which is a fast thing to do but depending on your tooling is a bit of a pain. I note this only for future reference; I think this PR is fine to go.

@erget erget merged commit 8d58b60 into cf-convention:main Jan 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants