Correct figures & add static assets to HTML check build #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pending contribution from @neumannd for finalisation. |
|
@erget I updated the figures but have to find out how to add things to your PR. I'll do it today afternoon (and update the text in the figure captions). |
|
@neumannd OK don't worry, this isn't urgent, I just like to make sure the next steps are clear before I switch tasks :) If you send me a PR to this branch from your branch I can merge it and it'll get included for pulling into the main repo. Let me know if you need a hand, I'll be around this afternoon. |
|
@erget I send you an email with the modified files. Hope, that I guessed your email adress correctly. |
correct indices of neighbour cells in @d case * update/correct order of indices i/j in Fig 2 (2D lon/lat bounds) * update/correct order of indices i/j in caption of Fig 2 * rename "figure 1" to "figure 3" in Appendix i * correct indices of neighbour cells in @d case * update history Figures are generated from: https://github.com/neumannd/cell_bounds_figures_for_cf_conventions
erget
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #295 for discussion of these changes.
Release checklist
cf-conventions.adoc?cf-conventions.adocup to date? Versioning inspired by SemVer.history.adocup to date?For maintainers
After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then
masteralways is a draft for the next version.