missing ; (typo) #378
Merged
missing ; (typo) #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erget
added
the
defect
|
These changes look good to me. @davidhassell I think you're the lucky one to merge this in 3w if there are no objections; that would be the 13th, right in time for the workshop. Does that work for you? |
|
And thank you @edzer , that's clearly a typo and the correction is appreciated! :) |
|
Hi @erget - I'm happy to merge this right now - as in 3 weeks we'll already have released CF-1.10, but I'm willing to go out on a limb and say that there is no possible objection to this defect :). |
|
@davidhassell I agree, I've merged it now. If the CF police comes they'll hang us together ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corrected a typo