-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cf conventions deployment position #431
Merged
JonathanGregory
merged 11 commits into
cf-convention:main
from
fmanzano-pde:cf-conventions-deployment_position
Apr 5, 2023
Merged
Cf conventions deployment position #431
JonathanGregory
merged 11 commits into
cf-convention:main
from
fmanzano-pde:cf-conventions-deployment_position
Apr 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed example H.5 to H.5a Added new example H.5b to describe the situation of a single timeseries with time-varying deviations from a nominal point spatial location **that also can change after redeployments**
5 Coordinate Systems and Domain --> Three exceptions for "the dimensions of each auxiliary coordinate must be a subset of the dimensions of the variable they are attached to". Added the second.
Changing "array" by "variable" would suit better.
Added reference to example H.5 and extra information in section Lossless Compression by Gathering
Changed reference example A9.2.3.2. to correct reference example H.5
Example H5 extended to add changes in deployment location
Added extra info in H.5 example. Lossless compression by gathering applied to the deployment coordinate variables.
Revision history: new line Issue 428 recording deployment positions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks fine to me, thanks.
I resolved the conflict in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #428 for discussion of these changes.
It is quite common that the deployment position of a station changes after maintenance or repositioning after it drifts. Example H.5. "A single timeseries with time-varying deviations from a nominal point spatial location" has been extended to show how these deployments can be encoded in CF. Lossless compression by gathering is applied to the deployment coordinate variables, which otherwise would contain a lot of missing or repetitive data.
Release checklist
cf-conventions.adoc
?cf-conventions.adoc
up to date? Versioning inspired by SemVer.history.adoc
up to date?For maintainers
After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then
master
always is a draft for the next version.