-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding colophon page for license, DOI and citation #570
Merged
cofinoa
merged 48 commits into
cf-convention:main
from
cofinoa:add-colophon-doi-citation
Dec 3, 2024
Merged
Adding colophon page for license, DOI and citation #570
cofinoa
merged 48 commits into
cf-convention:main
from
cofinoa:add-colophon-doi-citation
Dec 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lars Bärring <[email protected]>
Co-authored-by: Ethan Davis <[email protected]>
This was referenced Nov 14, 2024
Closed
cofinoa
added
CF1.12?
We might conclude this issue in time for CF1.12
enhancement
Proposals to add new capabilities, improve existing ones in the conventions, improve style or format
GitHub
Improvement to how we use GitHub for this repository
labels
Nov 14, 2024
larsbarring
reviewed
Nov 18, 2024
larsbarring
reviewed
Nov 18, 2024
…onment variables - Introduced environment variables for desired branch, path, and build type: - DESIRED_BRANCH: "gh-pages" - DESIRED_PATH: "/" - DESIRED_BUILD_TYPE: "legacy" - Simplified configuration management for GitHub Pages enforcement. - Improved maintainability by reducing hardcoded values across steps. - Ensured dynamic usage of environment variables in branch creation, artifact handling, and GitHub Pages setup.
- Skip the `publish_docs` job when the event is a Pull Request. - Add artifact upload link as a sticky comment in PRs. - Ensure `build_docs` and `publish_docs` jobs work for non-PR events (e.g., push, release). - Improve conditional logic for handling event types in the workflow.
- Removed `marocchino/sticky-pull-request-comment` step for PR events. - Added explicit artifact link output in the workflow logs. - Simplified workflow by guiding users to download artifacts via the Actions run page.
larsbarring
reviewed
Dec 2, 2024
larsbarring
force-pushed
the
add-colophon-doi-citation
branch
from
December 3, 2024 10:16
45ee3cf
to
9be2f79
Compare
larsbarring
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not an expert on the more technical aspects of the gh workflow machinery, but to me this looks all good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CF1.12?
We might conclude this issue in time for CF1.12
enhancement
Proposals to add new capabilities, improve existing ones in the conventions, improve style or format
GitHub
Improvement to how we use GitHub for this repository
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #513 for discussion of these changes.
This replaces PR #514 and PR #507
Note: This PR is based on pending changes for PR #568
Release checklist
cf-conventions.adoc
? Add in two places: on line 3 and under.Additional Authors
inAbout the authors
.cf-conventions.adoc
up to date? Versioning inspired by SemVer.history.adoc
up to date?For maintainers
After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then,
main
always is a draft for the next version.