Skip to content

Commit

Permalink
Remove singularity build as part of #737.
Browse files Browse the repository at this point in the history
  • Loading branch information
donkirkby committed Jul 31, 2018
1 parent 1f4d12d commit bb19322
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 12 deletions.
7 changes: 0 additions & 7 deletions kive/fleet/dockerlib.py
Original file line number Diff line number Diff line change
Expand Up @@ -379,13 +379,6 @@ def docker_is_alive(cls):
if cls.singularity_cmd_path is None:
raise RuntimeError('Cannot determine singularity command path')
logger.debug("singularity command path: '{}'".format(cls.singularity_cmd_path))
# docker repo
builddir = tempfile.mkdtemp()
test_image_name = os.path.join(builddir, "test.img")
build_command_str = cls._generate_build_string(DockerImage.DEFAULT_IMAGE,
test_image_name)
out_str = cls._run_shell_command(build_command_str.split())
logger.debug("singularity build returned: '{}'".format(out_str))
cls._is_alive = True
return True

Expand Down
3 changes: 1 addition & 2 deletions kive/fleet/tests_dockerlib.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ def setUp(self):
self.docker_handler_class = self.get_docker_handler_class()
is_docker_alive = self.docker_handler_class.docker_is_alive()
self.assertTrue(is_docker_alive)
print('SEEETUP')

def test_ident(self):
"""Test the docker_ident call"""
Expand Down Expand Up @@ -172,7 +171,7 @@ def test_gen_launch_cmd01(self):
assert isinstance(retlst, list), 'expected a list'
for s in retlst:
assert isinstance(s, six.string_types), 'expected a string'
lverb = True
lverb = False
if lverb:
print("got launch {}".format(retlst))
except NotImplementedError:
Expand Down
2 changes: 1 addition & 1 deletion kive/kive/settings_default.py
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@

# Attempt to run the system tests that use singularity
# NOTE: It only makes sense to have this true iff RUN_DOCKER_TESTS is also true
RUN_SINGULARITY_TESTS = False
RUN_SINGULARITY_TESTS = RUN_DOCKER_TESTS and False
14 changes: 12 additions & 2 deletions vagrant/bootstrap.sh
Original file line number Diff line number Diff line change
@@ -1,13 +1,23 @@
#!/usr/bin/env bash

yum install -y git libtool libarchive-devel squashfs-tools
yum install -y git libtool libarchive-devel squashfs-tools python-devel sqlite-devel

# Singularity
git clone https://github.com/singularityware/singularity.git
cd singularity
git checkout tags/2.5.2
git checkout -q tags/2.5.2
./autogen.sh
./configure --prefix=/usr/local
make
sudo make install
cd ..
rm -rf singularity

# pip
curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py
python get-pip.py pip==9.0.1
rm get-pip.py

# Kive
cd /usr/local/share/Kive
pip install -r requirements-dev.txt

0 comments on commit bb19322

Please sign in to comment.