Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old runs and pipelines #752

Closed
9 tasks done
donkirkby opened this issue Dec 17, 2018 · 4 comments
Closed
9 tasks done

Remove old runs and pipelines #752

donkirkby opened this issue Dec 17, 2018 · 4 comments
Assignees
Labels
config change includes a configuration change to release enhancement

Comments

@donkirkby
Copy link
Member

donkirkby commented Dec 17, 2018

Once all the old pipelines are converted to child containers in issue #751, we can remove all the code to support the old pipelines:

  • runs
  • fleet and sandbox
  • docker and slurmlib
  • pipelines, methods, transformations, and code resources
  • compound datatypes
  • delete orphaned datasets from MD5 conflicts
  • delete orphaned datasets from intermediate steps that weren't wired to pipeline outputs
  • add tests for removal plan
  • remove @types/jquery from package.json Can't remember why we wanted this, so postpone it for now.

Run the migrations and the find_orphans management command as part of deployment.

@donkirkby
Copy link
Member Author

What should we do about intermediate datasets that were not wired to pipeline outputs? They got recorded as datasets in the old runs, but they would not get created in the converted container runs.

Should we just delete the datasets? What about the MD5 conflict datasets? Should we delete those, too?

@rhliang
Copy link
Contributor

rhliang commented Mar 27, 2019

I think that's OK, considering they would have gotten purged in pretty short order otherwise anyway.

@donkirkby donkirkby self-assigned this Jun 13, 2019
@donkirkby donkirkby pinned this issue Jun 14, 2019
donkirkby added a commit that referenced this issue Jun 14, 2019
donkirkby added a commit that referenced this issue Jun 17, 2019
Renamed settings_default.py to settings.py, and put it under source control.
donkirkby added a commit that referenced this issue Jun 17, 2019
Remove old items from the main navigation menus.
donkirkby added a commit that referenced this issue Jun 19, 2019
donkirkby added a commit that referenced this issue Jun 19, 2019
Change Dataset.has_data to raise errors for missing or inaccessible files.
donkirkby added a commit that referenced this issue Jun 19, 2019
donkirkby added a commit that referenced this issue Jun 21, 2019
donkirkby added a commit that referenced this issue Jun 21, 2019
@donkirkby donkirkby assigned dmacmillan and unassigned donkirkby Dec 2, 2019
@dmacmillan
Copy link
Contributor

I wrote a django management script to handle orphaned datasets, which should clear the last two things off this list. The last thing to do would now be to update the test server where kive is running with the drop_pipeline branch. I think the test server is called bulbasaur but I still don't have access to it.

@donkirkby
Copy link
Member Author

Closed by 79617ae.

@donkirkby donkirkby unpinned this issue Dec 11, 2019
@donkirkby donkirkby added the config change includes a configuration change to release label Dec 12, 2019
donkirkby added a commit that referenced this issue Jan 31, 2020
Moved them into the container app.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config change includes a configuration change to release enhancement
Projects
None yet
Development

No branches or pull requests

3 participants