Adjust cf-support core dump finding to include more CFEngine binary l… #5619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocations For example, httpd is outside of /var/cfengine/bin but could still coredump and we want to catch that.
|
Thanks for submitting a PR! Maybe @larsewi can review this? |
craigcomstock
commented
Dec 19, 2024
| read -r response | ||
| fi | ||
| response=${response:-/var/cfengine/bin} | ||
| response=${response:-/var/cfengine} | ||
| if [ "$response" != "n" ]; then | ||
| # file command on core files results in lines like the following which we parse for cf-* binaries | ||
| # core: ELF 64-bit LSB core file, x86-64, version 1 (SYSV), SVR4-style, from '/var/cfengine/bin/cf-key', real uid: 0, effective uid: 0, realgid: 0, effective gid: 0, execfn: '/var/cfengine/bin/cf-key', platform: 'x86_64' |
There was a problem hiding this comment.
this portion needs more work, we shouldn't parse for cf-* anymore as we might be dealing with httpd or other binaries from /var/cfengine so more research/testing must be done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ocations
For example, httpd is outside of /var/cfengine/bin but could still coredump and we want to catch that.