Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --rows-per-insert instead of merge_inserts.awk #2936

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

vpodzime
Copy link
Contributor

Older versions pg_dump didn't have this option so we had to use our custom AWK script to get a significant speed-up of loading dumps from feeders on a superhub. All versions of PostgreSQL CFEngine Enterprise is shipped with now have pg_dump supporting the new --rows-per-insert option.

Changelog: Data dumping on Federated Reporting feeders no longer
uses an AWK filter to merge INSERT lines in the dumps
Ticket: None

Older versions pg_dump didn't have this option so we had to use
our custom AWK script to get a significant speed-up of loading
dumps from feeders on a superhub. All versions of PostgreSQL
CFEngine Enterprise is shipped with now have pg_dump supporting
the new --rows-per-insert option.

Changelog: Data dumping on Federated Reporting feeders no longer
           uses an AWK filter to merge INSERT lines in the dumps
Ticket: None
@vpodzime vpodzime requested a review from craigcomstock July 30, 2024 09:05
3.12.x has not been supported for a while now.
@vpodzime
Copy link
Contributor Author

jenkins: Build Status

Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I don't mind AWK and I celebrate simplification. One less tool is a "good thing" (TM).

@vpodzime
Copy link
Contributor Author

Nice. I don't mind AWK and I celebrate simplification. One less tool is a "good thing" (TM).

We still give users a chance to user their own custom AWK and SED scripts. :)

@vpodzime vpodzime merged commit 71199ed into cfengine:master Jul 30, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants