Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate jumbo hero pattern from cf.gov to design system #6689

Merged
merged 8 commits into from
Nov 2, 2021

Conversation

contolini
Copy link
Member

Moves the jumbo hero styles into the DS.

How to test this PR

  1. See the testing steps at Migrate jumbo hero pattern from cf.gov, add new 50/50 hero, update hero grids design-system#1299

Screenshots

before after
before after

Notes and todos

  • We'll need to tag and release a new DS version and import it into cf.gov before rolling out the new homepage.

Checklist

  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • Consider prefixing, e.g., "Mega Menu: fix layout bug", or "Docs: Update Docker installation instructions".
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines
  • Future todos are captured in comments and/or tickets
  • Project documentation has been updated, potentially one or more of:
    • This repo’s docs (edit the files in the /docs folder) – for basic, close-to-the-code docs on working with this repo
    • CFGOV/platform wiki on GHE – for internal CFPB developer guidance
    • CFPB/hubcap wiki on GHE – for internal CFPB design and content guidance

Front-end testing

Browser testing

Visually tested in the following supported browsers:

  • Firefox
  • Chrome
  • Safari
  • Edge 18 (the last Edge prior to it switching to Chromium)
  • Internet Explorer 11 and 8 (via emulation in 11's dev tools)
  • Safari on iOS
  • Chrome on Android

Accessibility

  • Keyboard friendly (navigable with tab, space, enter, arrow keys, etc.)
  • Screen reader friendly
  • Does not introduce new errors or warnings in WAVE

Other

  • Is useable without CSS
  • Is useable without JS
  • Does not introduce new lint warnings
  • Flexible from small to large screens

@contolini contolini changed the base branch from ans_new_hp_designs to main September 30, 2021 19:09
@contolini contolini marked this pull request as draft October 7, 2021 15:24
@contolini contolini marked this pull request as ready for review November 2, 2021 19:57
@contolini contolini changed the base branch from main to ans_new_hp_designs November 2, 2021 20:48
@contolini contolini changed the base branch from ans_new_hp_designs to main November 2, 2021 20:55
@contolini contolini changed the base branch from main to ans_new_hp_designs November 2, 2021 20:56
@contolini contolini merged commit a747150 into ans_new_hp_designs Nov 2, 2021
@contolini contolini deleted the jumbo-hero branch November 2, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants