Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alert] Width restriction; Icon positioning and coloring #388

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Nov 19, 2024

Close #386
Close #387

TODO

  • Verify all existing tests pass

Changes

  • feature: Restrict width of Alert explanation text to 670px
  • fix: Allow icons within field-level Alert content (i.e. external links) to display inline and color-matched
  • stories: Better align Story content of DSR with DS examples, while also demonstrating the unique capabilities of DSR

How to test

Review the preview deployment

Screenshots

alert_width-and-icon

Sorry, something went wrong.

[Alert] Allow icons within alert content to remain inline
…e also demonstrating the unique features implemented via DSR
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for cfpb-design-system-react ready!

Name Link
🔨 Latest commit 5087800
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/6752200cc984cb00087d1955
😎 Deploy Preview https://deploy-preview-388--cfpb-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@meissadia meissadia changed the title 386 alert fixes [Alert] Width restriction; Icon positioning and coloring Nov 19, 2024
@meissadia meissadia requested review from natalia-fitzgerald and removed request for ojbravo November 19, 2024 21:10
@meissadia meissadia marked this pull request as draft November 19, 2024 21:51
@meissadia meissadia marked this pull request as ready for review November 19, 2024 23:29
@meissadia meissadia merged commit c1b6d96 into main Dec 6, 2024
8 of 10 checks passed
@meissadia meissadia deleted the 386-alert-fixes branch December 6, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug][Alert] Icons within Alert content should not shift out of place [Alert] Content text max width 670px
2 participants