Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6 add OIDC auth to mail api #12

Merged
merged 4 commits into from
Feb 13, 2024
Merged

6 add OIDC auth to mail api #12

merged 4 commits into from
Feb 13, 2024

Conversation

jcadam14
Copy link
Contributor

@jcadam14 jcadam14 commented Feb 9, 2024 •
edited
Loading

Closes #6

  • Added integration with Oauth2/Keycloak from the regtech-api-commons lib
  • Added @required to root GET and /send POST
  • Added pytests to test unauthed and authed versions of endpoints, including testing response from /send
  • Added pytest env vars to support settings (mail-api and keycloak settings) during testing

With #8 merged into this branch (on a separate clone I used), coverage got to 85% ;)

@jcadam14 jcadam14 linked an issue Feb 9, 2024 that may be closed by this pull request
Add OIDC auth to Mail API #6
Closed
@jcadam14 jcadam14 self-assigned this Feb 9, 2024
hkeeler
hkeeler previously approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@hkeeler hkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think there's just a merge conflict to resolve.

lchen-2101
lchen-2101 previously approved these changes Feb 13, 2024
View reviewed changes
Copy link

@lchen-2101 lchen-2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lchen-2101
Copy link

oop, conflict again 😂

@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  regtech_mail_api
  api.py
  mailer.py
  models.py
  settings.py
Project Total  

This report was generated by python-coverage-comment-action

lchen-2101
lchen-2101 approved these changes Feb 13, 2024
View reviewed changes
Copy link

@lchen-2101 lchen-2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lchen-2101 lchen-2101 merged commit 1b6651c into main Feb 13, 2024
3 checks passed
@lchen-2101 lchen-2101 deleted the 6-add-oidc-auth-to-mail-api branch February 13, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchen-2101 lchen-2101 lchen-2101 approved these changes

@hkeeler hkeeler Awaiting requested review from hkeeler

Assignees

@jcadam14 jcadam14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OIDC auth to Mail API
3 participants
@jcadam14 @lchen-2101 @hkeeler