5 create helm charts for regtech mail api and mailpit #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
This PR does not seem to contain any modification to coverable code. |
hkeeler
reviewed
Feb 23, 2024
There was a problem hiding this comment.
This all looks good to me. As far as where this code belongs, though, I'm going to leave that up to @gduncklee. He has more the a master plan for Helm charts and values. I get that this one is a bit of an oddball since it's not part of the production stack.
gduncklee
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5
See PR #44 in the EKS repo for Helm values files for the mailing-api. These use the standard Helm templates in the sbl-deployment repo.
Hardcoded most of this since I feel like there isn't a ton of need for flexibility here but will gladly helmatize it more if y'all would prefer. Or move these completely into the EKS repo instead of here.