fix: only insert types history if it's not empty #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchen-2101
requested review from
hkeeler,
guffee23,
jcadam14 and
nargis-sultani
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
hkeeler
reviewed
Mar 19, 2024
tests/entities/test_listeners.py
Outdated
Comment on lines
80
to
81
| no_types = deepcopy(self.target) | ||
| delattr(no_types, "sbl_institution_types") |
There was a problem hiding this comment.
Is everything identical to the above test with the exception of these two lines? It seems like it, but my eyeball 👁️ diff is only so good.
There was a problem hiding this comment.
yeap, only removed the types from the dao
There was a problem hiding this comment.
...and is deleting the sbl_institutions_types attribute from the object really simulating what will happen in the case? Is it not enough to just make it None or an empty list?
There was a problem hiding this comment.
yeap, empty list works, actually that probably simulates the actual flow better, I'll update that; setting None makes it incompatible type.
hkeeler
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #127