Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added institutions api tests #15

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Added institutions api tests #15

merged 1 commit into from
Aug 25, 2023

Conversation

guffee23
Copy link
Contributor

Added pytests for institutions api and added groups to authenticated user.

@guffee23
Added institutions api tests
1148aee 
Added pytests for institutions api and added groups to authenticated user.
@guffee23
Copy link
Contributor Author

Closes Issue #2

lchen-2101
lchen-2101 approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@lchen-2101 lchen-2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, most of the institution modifications endpoints are meant for internal admin users, some might get removed as this API should be read-only majority if not all of the time; but topic for another day.

@lchen-2101 lchen-2101 merged commit e8516f5 into main Aug 25, 2023
@lchen-2101 lchen-2101 deleted the feature/2_add_api_tests branch August 25, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchen-2101 lchen-2101 lchen-2101 approved these changes

@hkeeler hkeeler Awaiting requested review from hkeeler

@ethanbienstock ethanbienstock Awaiting requested review from ethanbienstock

@aharjati aharjati Awaiting requested review from aharjati

@nargis-sultani nargis-sultani Awaiting requested review from nargis-sultani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guffee23 @lchen-2101