Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[View Institution profile] Update language #1013

Closed
Tracked by #287
meissadia opened this issue Oct 17, 2024 · 0 comments · Fixed by #1024
Closed
Tracked by #287

[View Institution profile] Update language #1013

meissadia opened this issue Oct 17, 2024 · 0 comments · Fixed by #1024
Assignees
@meissadia
Labels
enhancement New feature or request

Comments

@meissadia
Copy link
Contributor

meissadia commented Oct 17, 2024 •
edited
Loading

Institution profile: http://localhost:8899/institution/123456789TESTBANK123

  • Language
    • Most unpopulated fields: "Not available" => "Not applicable"
    • Refer to table for which unpopulated fields should be shown as blank
  • Add warning alert for the "Not provided" fields
    Image
@meissadia meissadia self-assigned this Oct 17, 2024
@meissadia meissadia added the enhancement New feature or request label Oct 17, 2024
This was referenced Oct 18, 2024
Closed
Merged
@meissadia meissadia changed the title [Institution profile] Update language, add error alert [View Institution profile] Update language, add error alert Oct 22, 2024
@meissadia meissadia changed the title [View Institution profile] Update language, add error alert [View Institution profile] Update language Oct 28, 2024
This was referenced Oct 30, 2024
Closed
Open
Closed
@meissadia meissadia mentioned this issue Nov 6, 2024
Merged
meissadia added a commit that referenced this issue Dec 10, 2024
@meissadia @tanner-ricks
Upgrade to Node v22 (#1047)
1143bfe 
Close #1040 

## Changes

- [e2e] Update tests for `View Institution Profile` that were missed as
part of #1013
- [fix] [View Institution Profile] Display alert when
`sbl_institution_types` is `null` or `[]`
- Updated `.nvmrc` to use `v22`
- Updated `package.json -> engines` to use Node v22
- Update Github actions to use Node v22
- Updated Dockerfile to use new `node-js-alpine:3.20` base image

## How to test this PR

1. Pull branch
2. `nvm use`
3. `yarn start` to easily launch all backend services
4. `yarn docker-build-and-run` to run the container version of the
Frontend
5. Update your `.env` file to run tests against the container version
   ```
   SBL_PLAYWRIGHT_TEST_TARGET="http://localhost:8085"
   ```
6. `yarn playwright test --workers 4`
7. Verify all tests pass

---------

Co-authored-by: tanner-ricks <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meissadia meissadia

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[View Institution Profile] Language updates cfpb/sbl-frontend
1 participant
@meissadia