-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input_file_handling_robustness #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some small comments.
Regarding the Alogrithm.empty()
, I'm not sure if I follow how it would be used. If you have a case that doesn't specify any algorithms, what would you do with that case?
19a2721
to
6ba77c4
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more tiny comment, otherwise looks great 👍
Co-authored-by: Christoph Hasse <[email protected]>
This PR makes the input file handling routines more flexible and robust.
grid
entry in the input file. You can now run a scalar case.algorithm
entry in the input file. This makes aAlgorithm.empty
which does nothing at all (neater than handling no algorithms as some special case).sanitize_variable
which works around scalar-valued coordinates (see Multiple methods fail on a DataArray with scalar dimension pydata/xarray#1709). This has the pleasing side-effect of getting the correct dimension name in the regression JSON.cfspopcon
as an entry point, equivalent topopcon
. Now you can eitherpoetry run popcon
orpoetry run cfspopcon
— these do the same thing.input_file_handling
instead of just filepaths, in case you want to programmatically set input values.ruff
ontests
to tidy this up