-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved error messages from wraps_ufunc #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments. Would you mind making sure to run pre-commit
locally to fix the formatting error the CI is complaining about?
cfspopcon/formulas/scrape_off_layer/two_point_model/momentum_loss_functions.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, thanks Tom 👍
wraps_ufunc
input_units
don't match function parameterswraps_ufunc
-wrapped function don't match the expected argumentswraps_ufunc
-wrapped function don't match the number of returned unitsreturn_keys
isn't given as a list, converts to a list.[Algorithm.get_algorithm(key) for key in keys]
pattern.UNHANDLED
Example errors