-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement model to calculate edge impurity concentration #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
903b5ca
to
f310f9c
Compare
5538f1f
to
3e92cdd
Compare
2894ae3
to
c87de29
Compare
hassec
requested changes
Feb 8, 2024
cfspopcon/formulas/scrape_off_layer_model/edge_impurity_concentration.py
Show resolved
Hide resolved
3d7236d
to
2c0709e
Compare
hassec
approved these changes
Feb 28, 2024
@tbody-cfs What is the extent of this update? Does it help already to solve https://github.com/cfs-energy-internal/POPSIM/issues/28? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request adds in the "Lengyel model", as described in
The Lengyel model was originally presented in a 1981 IPP report "Analysis of Radiating Plasma Boundary Layers" by L. L. Lengyel, report number 1/191
The model gives the concentration of a radiating impurity required to achieve a requested radiative power dissipation fraction in the SOL. Usually, the calculated concentration can be related to the concentration from a higher-fidelity model such as SOLPS (see Moulton paper) via a constant factor, which we call the
lengyel_overestimation_factor
.