Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): remove incorrect --with flag in install command #71

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

hassec
Copy link
Collaborator

@hassec hassec commented Jul 24, 2024

The installation instructions incorrectly pass a --with dev to the pip install cfspopcon.

While poetry has a --with flag, pip doesn't have a --with flag. And poetry dev dependencies aren't something one can install via a pip command, so just removing this.

I've tested that just a simple

pip install cfspopcon
radas -d ./radas_dir

still works.

@hassec hassec requested a review from tbody-cfs July 24, 2024 18:37
@tbody-cfs tbody-cfs merged commit ea571f7 into main Jul 24, 2024
8 checks passed
@tbody-cfs tbody-cfs deleted the fix_docs branch July 24, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants