Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): ensure pytest turns warnings into errors #84

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

hassec
Copy link
Collaborator

@hassec hassec commented Jul 31, 2024

Adds

filterwarnings = [
  "error",
  "ignore:numpy.ndarray size changed, may indicate binary incompatibility. Expected 16 from C header, got 96 from PyObject"
]

to our pyproject.toml.

The first is to turn all warnings into errors.
Line 2 is to ignore the numpy compatibility warnings that netcdf4 generates.

@tbody-cfs
Copy link
Collaborator

Nice!

ValueError: The following units are not recognized:
dilution_change_from_core_rad: ducks
edge_impurity_concentration_in_core: chickens

@tbody-cfs tbody-cfs merged commit 988cace into main Jul 31, 2024
8 checks passed
@tbody-cfs tbody-cfs deleted the pytest_warnings branch July 31, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants