Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated formula and add separatrix_electron_temp as Algorithm #91

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

tbody-cfs
Copy link
Collaborator

No description provided.

@tbody-cfs tbody-cfs requested a review from hassec August 19, 2024 17:26
Copy link
Collaborator

@hassec hassec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a nice cleanup 👍

Just one open question

cfspopcon/variables.yaml Show resolved Hide resolved
@tbody-cfs tbody-cfs enabled auto-merge (squash) September 11, 2024 15:46
@tbody-cfs tbody-cfs merged commit 927e8c8 into main Sep 11, 2024
6 checks passed
@tbody-cfs tbody-cfs deleted the Tidy_up_SOL_models branch September 11, 2024 16:08
AudreySaltzman pushed a commit to AudreySaltzman/cfspopcon that referenced this pull request Sep 12, 2024
…hm (cfs-energy#91)

* Remove duplicated formula and add separatrix_electron_temp as Algorithm

* Rename parallel_heat_flux_density to q_parallel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants