Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action to build and test #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zspitzer
Copy link

  • had to move the suite test case to a subdir, as the lucee test suite skips any tests in a folder with an Application.cfc

one test is failing

[java] [script] can add and retrieve a bit value correctly
[java] [script]
[java] [script] Failed: Expected [java.lang.Boolean] but received [java.lang.Double]
[java] [script] /home/runner/work/lucee-mariadb/lucee-mariadb/test/tests/mariaDb.cfc:66
[java] [script] /home/runner/work/lucee-mariadb/lucee-mariadb/lucee/test/_testRunner.cfc:409
[java] [script] /home/runner/work/lucee-mariadb/lucee-mariadb/lucee/test/run-tests.cfm:218
[java] [script] /bootstrap-tests.cfm:108

@cfsimplicity
Copy link
Owner

@zspitzer Thanks Zac. I'm still a GHA noob. A lot of this is beyond me!

The test is failing because my master branch (which you forked) still had a copy of the older 2.7.1 driver jar in the extension/jars folder (I'd got rid of it in develop but not in master - don't know how that happened). That means your build had both 2.x and 3.x jars and 2.x was winning out. That version is expected to fail because they changed the type for bit from Double to Boolean in 3.x

I've updated master now to remove the old jar.

@zspitzer zspitzer force-pushed the add-gha branch 2 times, most recently from 7919fba to fa0c096 Compare December 14, 2022 13:13
@zspitzer
Copy link
Author

ok, i rebased and it's all green now :)

there's a bit of learning curve but you can use this a a template for any of your projects

only main gotcha is that the lucee test runner expects it's own test case, any you need to add labels/filters to filter which tests are run

i.e.

- name: Run Lucee Test Suite (testFilter="mariaDb")
      uses: lucee/script-runner@main
      with:
        webroot: ${{ github.workspace }}/lucee/test
        execute: /bootstrap-tests.cfm
        luceeVersion: ${{ env.luceeVersion }}
        extensionDir: ${{ github.workspace }}/
      env:
        testLabels: mariaDb  # or 
        testFilter: mariaDb # or
        testAdditional: ${{ github.workspace }}/test
        testBaseSpec: testbox.system.BaseSpec # TODO

i.e. component extends="org.lucee.cfml.test.LuceeTestCase" labels="mariaDb"

but i'll make that flexible https://luceeserver.atlassian.net/browse/LDEV-4324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants