feat(base-input): add icons props

cft-group · Aug 10, 2020 · e5327bd · e5327bd
1 parent 9bd9617
commit e5327bd
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 16 deletions.
diff --git a/src/packages/core/src/base-input/BaseInput.tsx b/src/packages/core/src/base-input/BaseInput.tsx
@@ -11,13 +11,8 @@ export function BaseInput<T extends HTMLAttributesComposite>(props: BaseInputPro
     error,
     hint,
     label,
-    name = '',
-    onBlur,
-    onChange,
-    onFocus,
-    onKeyDown,
-    value,
     width = '100%',
+    icons,
     ...rest
   } = props;
 
@@ -34,25 +29,24 @@ export function BaseInput<T extends HTMLAttributesComposite>(props: BaseInputPro
       {/* eslint-disable-next-line jsx-a11y/label-has-associated-control */}
       <label className="_e_input__field">
         {
-          cloneElement(children, {
+          cloneElement<T>(children, {
             className: '_e_input__control',
             disabled: appearance === 'disabled',
-            name,
-            onChange,
-            onFocus,
-            onBlur,
-            onKeyDown,
             placeholder: ' ',
             readOnly: appearance === 'readonly',
-            value,
             ...rest,
           })
-        }
+         }
         <span className="_e_input__label">
           { label }
         </span>
         <span className="_e_input__background" />
         <span className="_e_input__line" />
+        { icons && (
+          <div className="_e_input__icon">
+            { icons }
+          </div>
+        )}
       </label>
       {
         hint

diff --git a/src/packages/core/src/base-input/types.ts b/src/packages/core/src/base-input/types.ts
@@ -2,12 +2,13 @@ import {
   InputHTMLAttributes,
   TextareaHTMLAttributes,
   ReactElement,
+  ReactNode,
 } from 'react';
 
 export type HTMLAttributesComposite =
     | InputHTMLAttributes<HTMLInputElement>
-    | TextareaHTMLAttributes<HTMLTextAreaElement>
-    | InputHTMLAttributes<HTMLSelectElement>;
+    | InputHTMLAttributes<HTMLSelectElement>
+    | TextareaHTMLAttributes<HTMLTextAreaElement>;
 
 export type AbstractInput<T extends HTMLAttributesComposite> = T & {
   /**
@@ -31,6 +32,8 @@ export type AbstractInput<T extends HTMLAttributesComposite> = T & {
    */
   hint?: string;
 
+  icons?: ReactNode,
+
   /**
    * Field label.
    */