Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BiDAF embedding #10

Open
wants to merge 1 commit into
base: bidaf
Choose a base branch
from
Open

BiDAF embedding #10

wants to merge 1 commit into from

Conversation

Ishitori
Copy link

@Ishitori Ishitori commented Jul 6, 2018

Description

BiDAF embedding is done and tested using original SQuAD dataset

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • BiDAF embedding
  • Required preprocessing to launch the model

@Ishitori Ishitori changed the base branch from master to bidaf July 6, 2018 18:42
cgraywang
cgraywang approved these changes Jul 20, 2018
View reviewed changes
Copy link
Owner

@cgraywang cgraywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgraywang cgraywang cgraywang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ishitori @cgraywang