Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making SQuAD to return json (no public API change) #16

Open
wants to merge 1 commit into
base: bidaf
Choose a base branch
from

Conversation

Ishitori
Copy link

Description

Better responsibility separation. _read_data() now just only reads the json into memory, not parses it. It allows to get the json as-is later, if needed. I use it to plug in official evaluation script

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • _read_data method only reads json file, not parses it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant