assert: .fail() parameter mismatch. Closes #206

chaijs · Jan 29, 2014 · b01eba7 · b01eba7
1 parent 1e6b305
commit b01eba7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/lib/chai/interface/assert.js b/lib/chai/interface/assert.js
@@ -55,13 +55,12 @@ module.exports = function (chai, util) {
    */
 
   assert.fail = function (actual, expected, message, operator) {
-    throw new chai.AssertionError({
+    message = message || 'assert.fail()';
+    throw new chai.AssertionError(message, {
         actual: actual
       , expected: expected
-      , message: message
       , operator: operator
-      , stackStartFunction: assert.fail
-    });
+    }, assert.fail);
   };
 
   /**

diff --git a/test/assert.js b/test/assert.js
@@ -12,8 +12,8 @@ describe('assert', function () {
 
   it('fail', function () {
     chai.expect(function () {
-      assert.fail();
-    }).to.throw(chai.AssertionError);
+      assert.fail(0, 1, 'this has failed');
+    }).to.throw(chai.AssertionError, /this has failed/);
   });
 
   it('isTrue', function () {