Fix assertions on functions that throw primitives #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although not recommended, JavaScript functions can throw anything, i.e., not necessarily an
Error
.However, Chai does not nicely deal with them. Consider the following snippet of code:
Currently, line 2 incorrectly doesn't cause an error, but line 3 does:
This pull request adds support for primitive errors, correctly resulting in this error for line 2: