Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssfi as it should be #233

Merged
merged 1 commit into from
Feb 25, 2014
Merged

ssfi as it should be #233

merged 1 commit into from
Feb 25, 2014

Conversation

refack
Copy link

@refack refack commented Jan 18, 2014

No description provided.

@logicalparadox
Copy link
Member

This cannot automatically be merged. Can you rebase with upstream and reopen this PR?

Also, I see the following issues with your code.

  • Please do not include the browser build @ chai.js in your PR.
  • You made changes to the should interface loader. I don't see how this impacts ssfi and no explanation is given as to why it is changed.

@refack
Copy link
Author

refack commented Jan 30, 2014

Rebased, cleaned & commented.

logicalparadox added a commit that referenced this pull request Feb 25, 2014
@logicalparadox
Merge pull request #233 from Empeeric/master
07b34c7 
ssfi as it should be
@logicalparadox logicalparadox merged commit 07b34c7 into chaijs:master Feb 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refack @logicalparadox