Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update chain name #849

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

chore: Update chain name #849

wants to merge 41 commits into from
+2 −2

Conversation

cgilbe27
Copy link
Contributor

@cgilbe27 cgilbe27 commented Oct 29, 2024 •
edited
Loading

Also updated the naming to differentiate between environments

@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keplr-chain-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 1:49pm

@cgilbe27 cgilbe27 requested a review from editaahn November 1, 2024 14:46
@editaahn
Copy link
Collaborator

editaahn commented Nov 1, 2024

The changes for validation are not permitted for teams. Please respect the community's guidelines. Apologies for any inconvenience.

@cgilbe27
Copy link
Contributor Author

cgilbe27 commented Nov 1, 2024

The changes for validation are not permitted for teams. Please respect the community's guidelines. Apologies for any inconvenience.

Would I be able to do what injective has done here?

https://github.com/chainapsis/keplr-chain-registry/pull/849/files#diff-75c7cd2e7406d267a2ac4b539452dad618706ec21a1b4698ad0323355c3b409fR7

@editaahn
Copy link
Collaborator

editaahn commented Nov 4, 2024

@cgilbe27 Unfortunately we'll need to take additional steps within the applications to explicitly handle the different cases.

@cgilbe27
Copy link
Contributor Author

cgilbe27 commented Nov 8, 2024

@cgilbe27 Unfortunately we'll need to take additional steps within the applications to explicitly handle the different cases.

Is there anything we can do to help?

@cgilbe27
Copy link
Contributor Author

cgilbe27 commented Jan 7, 2025

Bump, I plan on splitting this MR

@editaahn
Copy link
Collaborator

editaahn commented Jan 8, 2025

@cgilbe27 Hey, we may need to adjust parts of our internal code for this kind of special case, but I’m afraid we don’t have sufficient resources to support it.

@cgilbe27 cgilbe27 marked this pull request as draft January 8, 2025 13:46
@cgilbe27 cgilbe27 changed the title chore: Add all nibiru environments chore: Update chain name Jan 8, 2025
@cgilbe27
Copy link
Contributor Author

cgilbe27 commented Jan 8, 2025

Hey @editaahn, I've removed the lower env changes, the only changes on this MR are to rename the chain

@cgilbe27 cgilbe27 marked this pull request as ready for review January 8, 2025 13:47
@editaahn
Copy link
Collaborator

editaahn commented Jan 9, 2025

@cgilbe27 Thank you! Since the validation fails and it might be caused by the stale branch, please pull the latest changes from the upstream branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@editaahn editaahn Awaiting requested review from editaahn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgilbe27 @editaahn