Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbom: update copyrightText from "/n" to "NOASSERTION" #1767

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

xnox
Copy link
Contributor

@xnox xnox commented Jan 30, 2025

There is logic bug interating all the copyright stanzas which always
appened a single "/n" into the copyrightText field of the SBOM
package.

The SPDX spec says that empty or whistespace only value should be
treated same as "NOASSERTION" when no determination was possible to
reach, or it was not attempted, or intentionally is not being
provided. However it is better to use "NOASSERTION" value to convey
this more exactly precise meaning.

See:

Fixes: https://github.com/chainguard-dev/internal-dev/issues/8822

There is logic bug interating all the copyright stanzas which always
appened a single "/n" into the copyrightText field of the SBOM
package.

The SPDX spec says that empty or whistespace only value should be
treated same as "NOASSERTION" when no determination was possible to
reach, or it was not attempted, or intentionally is not being
provided. However it is better to use "NOASSERTION" value to convey
this more exactly precise meaning.

See:
- https://spdx.github.io/spdx-spec/v2.3/package-information/#717-copyright-text-field
- https://spdx.github.io/spdx-spec/v3.0.1/model/Software/Properties/copyrightText/

Fixes: chainguard-dev/internal-dev#8822
@xnox xnox requested review from jspeed-meyers, luhring and a team January 30, 2025 03:30
@xnox xnox merged commit ba6c6d0 into chainguard-dev:main Jan 30, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants