Set a default env var for GOMODCACHE. #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Melange supports a filesystem based cache, but it's not used anywhere AFAICT. To use it for Go, we've documented how to set this env var. Instead of making everyone set it in every pipeline and build, let's just set it to the correct path by default in melange itself. This dramatically improves build times for me. Signed-off-by: Dan Lorenc <[email protected]>
luhring
approved these changes
Dec 8, 2023
| if cfg.Environment.Environment["GOPATH"] == "" { | ||
| cfg.Environment.Environment["GOPATH"] = defaultEnvVarGOPATH | ||
| var setIfEmpty = func(key, value string) { | ||
| if cfg.Environment.Environment[key] == "" { |
There was a problem hiding this comment.
This may be a pointless idea, but there's a chance it's better to use the , ok = style of check for map value emptiness rather than an empty string, in case we think the user would ever want to explicitly control the env variable to be empty at some point.
kaniini
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Melange supports a filesystem based cache, but it's not used anywhere AFAICT. To use it for Go, we've documented how to set this env var. Instead of making everyone set it in every pipeline and build, let's just set it to the correct path by default in melange itself.
This dramatically improves build times for me.
Melange Pull Request Template
Functional Changes
Notes: