Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pkg directory #47

Closed
imjasonh opened this issue Nov 26, 2023 · 2 comments · Fixed by #48
Closed

Remove pkg directory #47

imjasonh opened this issue Nov 26, 2023 · 2 comments · Fixed by #48
Assignees

Comments

@imjasonh
Copy link
Member

WDYT about moving everything under pkg up a level, so it's chainguard.dev/sdk/auth/aws, chainguard.dev/sdk/events/admission, chainguard.dev/sdk/uidp, etc.?

There's no conflict with proto, and it makes importpaths a little smaller and tidier. I'm not sure what kind of downstream breakages/refactors this would entail, but it's probably easier to do it now than later, if we ever want to do it.

@cmdpdx
Copy link
Collaborator

cmdpdx commented Nov 27, 2023

Good call out, I didn't consider this when moving out of mono. I have a PR I'm working on that switches refs in mono to use the public sdk. I've held off since @hectorj2f mentioned he had a proto change he wanted to get in before a new release of sdk. I can make this directory change and roll the path changes into my mono PR.

@hectorj2f
Copy link
Member

My PRs got merged. So I am good, as long as we use the sdk latest version of main.

octo-sts bot pushed a commit that referenced this issue Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants