Fix simple timestamp records broken OP_RETURN data if the prefix or data of Simple#set_data contain a single hexadecimal digit #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata of Simple#set_data contain a single hexadecimal digit
azuchi
approved these changes
Sep 21, 2023
Yamaguchi
requested changes
Sep 21, 2023
| @@ -23,7 +23,7 @@ def set_data(prefix, data) | |||
| @data = data | |||
|
|
|||
| contents = [prefix, data].map do |content| | |||
| content.bytes.map { |i| i.to_s(16) }.join | |||
| content.unpack1('H*') | |||
There was a problem hiding this comment.
content.bthのほうが少し簡単です。
contents = [prefix, data].map(&:bth)
Co-authored-by: Yamaguchi <[email protected]>
rantan
force-pushed
the
fix/timestamp
branch
from
b67dd73 to
7ba469a
Compare
Yamaguchi
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glueby::Contract::TimestampTxBuilder::Simple#set_dataの引数に HEX で１桁になる\u0001のような文字が含まれる場合に、２桁めの0が消えて桁がずれる問題を修正しました。