broadcast tx by internal wallet in payment contract #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azuchi
requested changes
Mar 30, 2021
azuchi
reviewed
Mar 31, 2021
spec/spec_helper.rb
Outdated
| status: :finalized | ||
| ) | ||
| end | ||
| end |
There was a problem hiding this comment.
Payment#transferがActiveRecordWalletAdapterを使ってペイメントを行い、UTXOレコードができることをテストするのが目的です。↑は、別のウォレット実装を使ったしたテストになっているので意図したテストになっていません。
azuchi
approved these changes
Mar 31, 2021
oshikawatkm
added a commit
to oshikawatkm/glueby
that referenced
this pull request
Apr 13, 2021
* broadcast tx by internal wallet in payment contract * add Utxo.count check on Payment test * modify broadcast Test in Payment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When broadcasting Tx in Payment contract, I made a change using the broadcast method of internal_wallet how to use RPC.
This is to fix the bug that Utxo is not created when using the active_record wallet.