Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Reissuable Token AR #52

Merged
merged 15 commits into from
May 27, 2021
Merged

Add Reissuable Token AR #52

merged 15 commits into from
May 27, 2021

Conversation

oshikawatkm
Copy link
Contributor

Implemented ActiveRecord to store ReissuableToken information.

@oshikawatkm oshikawatkm force-pushed the feature/confimed_balances branch from fefb27a to 9c92e24 Compare May 21, 2021 06:31
@rantan rantan self-requested a review May 24, 2021 05:58
rantan
rantan requested changes May 24, 2021
View reviewed changes
Copy link
Contributor

@rantan rantan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全体的にいい感じだと思います。

細かいところコメントしました。

lib/generators/glueby/contract/templates/reissuable_token_table.rb.erb Outdated Show resolved Hide resolved
lib/generators/glueby/contract/templates/reissuable_token_table.rb.erb Outdated Show resolved Hide resolved
lib/glueby/contract/token.rb Outdated Show resolved Hide resolved
lib/glueby/contract/token.rb Outdated Show resolved Hide resolved
lib/glueby/contract/token.rb Outdated Show resolved Hide resolved
lib/glueby/contract/token.rb Outdated Show resolved Hide resolved
lib/glueby/contract/token.rb Outdated Show resolved Hide resolved
lib/glueby/contract/token.rb Outdated Show resolved Hide resolved
lib/glueby/contract/token.rb Outdated Show resolved Hide resolved
spec/glueby/contract/token_spec.rb Show resolved Hide resolved
@oshikawatkm oshikawatkm force-pushed the feature/confimed_balances branch from dcfe70e to 60dc4bb Compare May 25, 2021 07:52
@oshikawatkm oshikawatkm requested a review from rantan May 25, 2021 07:58
@oshikawatkm oshikawatkm requested a review from rantan May 26, 2021 05:22
@oshikawatkm oshikawatkm requested a review from rantan May 26, 2021 09:04
@rantan rantan merged commit c85a16b into chaintope:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rantan rantan rantan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oshikawatkm @rantan