Add FeeProvider #54
Merged
Add FeeProvider #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azuchi
requested changes
May 25, 2021
rantan
force-pushed
the
add_fee_provider_2
branch
from
25ca54a to
b6280e6
Compare
…hich are processed in FeeProvider
…threads. There is a possibility of conflicts even if it is applied this change. We should consider more serious exclusive control like using Mutex or RDB atomicity.
rantan
force-pushed
the
add_fee_provider_2
branch
from
b6280e6 to
5bea5f7
Compare
azuchi
reviewed
May 26, 2021
| class FeeProvider | ||
| include Singleton | ||
|
|
||
| class NoUtxosInUtxoPool < StandardError; end |
There was a problem hiding this comment.
NoUtxosInUtxoPool is a word inside FeeProvider, so it is desirable to have a word that users can understand, like InsufficientFee.
There was a problem hiding this comment.
今の作り方だと、UTXO pool についてユーザには意識してもらう必要がどうしてもあるかと思います。poolが枯渇しないように管理するのはユーザの責任担ってしまうので。もちろんそのための rake タスク等は用意しますが。
UTXOについて完全にユーザに意識させないようにするには、別のアプローチを考える必要があると思います。
There was a problem hiding this comment.
APIとかで使う場合は、これらをキャッチして別のエラーとして返すという認識ですか？
There was a problem hiding this comment.
そうですね。APIで使う場合にこのエラーが出たら 500 番台のエラーになると思いますし、リカバリは API 側の責任かと思います。
azuchi
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds FeeProvider feature
What this PR doesn't do(and it going to be another PRs)
glueby:fee_provider:manage_utxo_poolrake taskglueby:fee_provider:statusrake task