Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colored coin feature #22

Merged
merged 6 commits into from
Jul 2, 2020
Merged

Colored coin feature #22

merged 6 commits into from
Jul 2, 2020

Conversation

Yamaguchi
Copy link
Contributor

This PR will add support for Colored Coin feature.

  • Add OP_COLOR opcode.
  • Defind TokenTypes enum and ColorIdentifier struct
  • Factory methods for ColorIdentifier (reissuable(), non_reissuable(), nft())
  • Utility methods for Script (is_cp2pkh, is_cp2sh, add_color)

@Yamaguchi Yamaguchi force-pushed the feature/colored_coin branch 2 times, most recently from 4826816 to 0d50f03 Compare July 1, 2020 06:39
azuchi
azuchi reviewed Jul 1, 2020
View reviewed changes
src/blockdata/opcodes.rs Outdated
@@ -677,7 +678,9 @@ impl All {
// 75 opcodes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// 75 opcodes
// 74 opcodes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed at ca26b4a

@Yamaguchi Yamaguchi force-pushed the feature/colored_coin branch from 0d50f03 to 4e0f22a Compare July 1, 2020 11:40
@Yamaguchi Yamaguchi requested a review from azuchi July 1, 2020 13:24
@azuchi azuchi merged commit 3b607e7 into chaintope:master Jul 2, 2020
@rantan rantan mentioned this pull request Jun 3, 2024
Open
19 tasks
@rantan rantan mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azuchi azuchi Awaiting requested review from azuchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yamaguchi @azuchi