Add signature_hash xfield and #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azuchi
requested changes
Nov 6, 2023
Naviabheeman
force-pushed
the
NewXFieldHash
branch
from
f78562d to
8b2c953
Compare
add new error type for the same
azuchi
requested changes
Nov 20, 2023
azuchi
requested changes
Nov 27, 2023
src/blockdata/block.rs
Outdated
| /// Return hash of serialized XField for signing | ||
| pub fn signature_hash(&self) ->Result<XFieldHash, Error> { | ||
| match self { | ||
| XField::None => Ok(XFieldHash::from_str("").unwrap()), |
There was a problem hiding this comment.
This code is intended to return a hash of an empty string, but it actually panics at XFieldHash::from_str("").unwrap(). And test case xfield_signature_hash_test_none also seems to expect that.
If you want to generate an error when None, XFieldHash::from_str("") is not necessary. On the other hand, if you return a hash for empty data, there should be no error.
There was a problem hiding this comment.
The idea was to return an empty string as the hash. But the hash constructor rejects it after checking the length. I never realised it as it doesn't happen in any real test scenario. I'll return error and fix the unit test.
…s None and fix its unit test
azuchi
approved these changes
Nov 29, 2023
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new hash type called XfieldHash to get the hash of serialised xfield. This is used during tapyrus-signer setup to generate a threshold signature for new xfield changes.