Use only spendable output related with contract #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10661143799Details
💛 - Coveralls |
Yamaguchi
force-pushed
the
use_only_spendable_output
branch
5 times, most recently
from
3445a1f to
7204a96
Compare
rantan
reviewed
Aug 14, 2024
crates/wallet/src/wallet/mod.rs
Outdated
Comment on lines
1046
to
1057
| let index = match self | ||
| .indexed_graph | ||
| .index | ||
| .index_of_spk(ScriptBuf::new_p2pkh(&payment_base.pubkey_hash()).as_script()) | ||
| { | ||
| Some(i) => i, | ||
| None => { | ||
| return Err(GenerateContractError::InvalidPublicKey { | ||
| public_key: payment_base.clone(), | ||
| }) | ||
| } | ||
| }; |
There was a problem hiding this comment.
index の値を使っていないようですが、必要な処理ですか？
また、この処理だと外部で作成された公開鍵をもとに pay to contract address を計算仕様とすると、InvalidPublicKey のエラーになるのではと思いますが、送金先のアドレスを計算するために、外部のウォレットの公開鍵から pay to contract address を計算するユースケースはあると思うので、エラーにするべきではないと思います。
There was a problem hiding this comment.
これ自体は
#28 (comment)
の指摘があって、追加してますが。追加する位置を変更します。
Yamaguchi
force-pushed
the
use_only_spendable_output
branch
3 times, most recently
from
2860b44 to
2d55a71
Compare
Yamaguchi
force-pushed
the
use_only_spendable_output
branch
from
1b08352 to
7500526
Compare
|
#31 でマージしました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements TxBuilder#add_contract_utxo to add utxo to tx_builder related with contract
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: