tapyrify the chain crate #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rantan
force-pushed
the
tapyrus_chain_crate
branch
4 times, most recently
from
1ca0067 to
ec651a4
Compare
rantan
force-pushed
the
tapyrus_chain_crate
branch
from
ec651a4 to
1c7c1e0
Compare
Due to the Tapyrus conversion, the TXID values changed, causing the order of transactions sorted lexicographically by TXID to change, which resulted in the test failures.
Yamaguchi
requested changes
Jun 20, 2024
| @@ -113,12 +114,12 @@ fn test_tx_conflict_handling() { | |||
| }, | |||
| ], | |||
| // the txgraph is going to pick tx_conflict_2 because of higher lexicographical txid | |||
There was a problem hiding this comment.
Txidが変わったためと思って良いですかね。
Suggested change
| // the txgraph is going to pick tx_conflict_2 because of higher lexicographical txid | |
| // the txgraph is going to pick tx_conflict_1 because of higher lexicographical txid |
There was a problem hiding this comment.
はい、txid が変わったので、辞書順のソートが変わってしまった影響です。
| @@ -14,7 +14,7 @@ jobs: | |||
| clippy: true | |||
| - version: 1.63.0 # MSRV | |||
| features: | |||
| - --no-default-features | |||
| - --no-default-features --features tapyrus/no-std,miniscript/no-std,hashbrown | |||
There was a problem hiding this comment.
後半の--features tapyrus/no-std,miniscript/no-std,hashbrownは必要?
There was a problem hiding this comment.
tapyrus crate は stdか no-std のどちらかの feature を有効にしないとビルドに失敗するんですが、これをつけないとそのために失敗します。
ただ、もともとなかった指定なので、なぜ必要になったのかよくわかっていないです。
Yamaguchi
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.