-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused risc0 host & introduce local proving #1326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Less code > more code
tbf, I would keep the local risc0 host :D how are we gonna do local proving if we delete it? |
can't we use a single host (existing Risc0BonsaiHost) for that? if there is no bonsai-key, and specified proving mode is |
ok let's do that in this PR then also move the risc0 guest to risc0bonsai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requesting changes so that this doesnt get merged accidentally.
One more thing to improve can be how Risc0Host was implemented. I guess the code was written for older versions of risc0. Checkout the newer examples from risc0 and try to see if we can make better use of it |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
768d192
to
caef8a0
Compare
b7051b4
to
6e41a34
Compare
6e41a34
to
f108804
Compare
Description
Removes a Risc0Host that is not used in the code other than tests.
Also introduce local proving to Risc0BonsaiHost. Added a test for it as well, but it timed-out even with 3 hours wait in my local machine. Hence I marked it as ignore. In the future when we add metal or cuda support to local proving, it still could be useful to run locally.
Linked Issues
Testing
Describe how these changes were tested. If you've added new features, have you added unit tests?
Docs
Describe where this code is documented. If it changes a documented interface, have the docs been updated?