Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused risc0 host & introduce local proving #1326

Merged
merged 16 commits into from
Oct 16, 2024

Conversation

yaziciahmet
Copy link
Contributor

@yaziciahmet yaziciahmet commented Oct 11, 2024

Description

Removes a Risc0Host that is not used in the code other than tests.

Also introduce local proving to Risc0BonsaiHost. Added a test for it as well, but it timed-out even with 3 hours wait in my local machine. Hence I marked it as ignore. In the future when we add metal or cuda support to local proving, it still could be useful to run locally.

Linked Issues

  • Fixes # (issue, if applicable)
  • Related to # (issue)

Testing

Describe how these changes were tested. If you've added new features, have you added unit tests?

Docs

Describe where this code is documented. If it changes a documented interface, have the docs been updated?

Copy link
Contributor

@kpp kpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less code > more code

@eyusufatik
Copy link
Member

tbf, I would keep the local risc0 host :D

how are we gonna do local proving if we delete it?

@yaziciahmet
Copy link
Contributor Author

tbf, I would keep the local risc0 host :D

how are we gonna do local proving if we delete it?

can't we use a single host (existing Risc0BonsaiHost) for that? if there is no bonsai-key, and specified proving mode is prove, we can configure it to do local proving.

@eyusufatik
Copy link
Member

can't we use a single host (existing Risc0BonsaiHost) for that? if there is no bonsai-key, and specified proving mode is prove, we can configure it to do local proving.

ok let's do that in this PR

then also move the risc0 guest to risc0bonsai

Copy link
Member

@eyusufatik eyusufatik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting changes so that this doesnt get merged accidentally.

@eyusufatik
Copy link
Member

One more thing to improve can be how Risc0Host was implemented.

I guess the code was written for older versions of risc0. Checkout the newer examples from risc0 and try to see if we can make better use of it

@yaziciahmet yaziciahmet added the HOLD-MERGE PR is not draft but should not be merged yet label Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 15.62500% with 54 lines in your changes missing coverage. Please review.

Project coverage is 77.7%. Comparing base (f4e3f56) to head (4c2914a).
Report is 1 commits behind head on nightly.

Files with missing lines Patch % Lines
crates/risc0-bonsai/src/host.rs 15.6% 54 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/sovereign-sdk/adapters/risc0/src/host.rs 100.0% <ø> (+73.2%) ⬆️
crates/risc0-bonsai/src/host.rs 17.5% <15.6%> (-0.4%) ⬇️

... and 2 files with indirect coverage changes

@yaziciahmet yaziciahmet force-pushed the yaziciahmet/remove-unused-risc0host branch from 768d192 to caef8a0 Compare October 15, 2024 10:36
@yaziciahmet yaziciahmet changed the title Remove unused risc0 host Remove unused risc0 host & introduce local proving Oct 15, 2024
@yaziciahmet yaziciahmet force-pushed the yaziciahmet/remove-unused-risc0host branch 2 times, most recently from b7051b4 to 6e41a34 Compare October 15, 2024 16:30
@yaziciahmet yaziciahmet force-pushed the yaziciahmet/remove-unused-risc0host branch from 6e41a34 to f108804 Compare October 15, 2024 17:10
@yaziciahmet yaziciahmet removed the HOLD-MERGE PR is not draft but should not be merged yet label Oct 15, 2024
@yaziciahmet yaziciahmet merged commit c63a83d into nightly Oct 16, 2024
14 checks passed
@yaziciahmet yaziciahmet deleted the yaziciahmet/remove-unused-risc0host branch October 16, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants