Fix mempool space inf loop bug

[ercecan]

Fixes bug where if mempool space returns error causes inf loop in sequencer

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.4%. Comparing base (16dac23) to head (9fb4844).
Report is 2 commits behind head on nightly.

Additional details and impacted files

Files with missing lines	Coverage Δ
crates/bitcoin-da/src/service.rs	51.2% <100.0%> (-0.2%)	⬇️

... and 2 files with indirect coverage changes

[yaziciahmet]

On a second thought, maybe this is not the right approach to fix this issue. Technically, anything within that loop can fail, db file may be corrupted, or any other rpc call to Bitcoin might fail. And all of these errors within that loop would result in an infinite loop. I don't think the best solution is to try to ignore the error or trying to replace it with a default value. But rather have some sort of exponential backoff retry mechanism within the loop, and have great logging + monitoring + alert systems.

[eyusufatik]

On a second thought, maybe this is not the right approach to fix this issue. Technically, anything within that loop can fail, db file may be corrupted, or any other rpc call to Bitcoin might fail. And all of these errors within that loop would result in an infinite loop. I don't think the best solution is to try to ignore the error or trying to replace it with a default value. But rather have some sort of exponential backoff retry mechanism within the loop, and have great logging + monitoring + alert systems.

That's correct.

For the fee stuff, it's already retried whenever it's used though.

And chances of estimatesmartfee failing is very low.