-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check compressed sequencer commitments #1349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakanalh
changed the title
Rakanalh/compress sequencer commitments
Check compressed sequencer commitments
Oct 16, 2024
auto-assign
bot
requested review from
ercecan,
eyusufatik,
jfldde,
kpp and
yaziciahmet
October 16, 2024 21:07
kpp
reviewed
Oct 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
eyusufatik
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very solid PR
eyusufatik
approved these changes
Oct 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses
TaskManager
to spawn a new task for runningCommitmentService
which in turn handles everything related to submitting sequencer commitments.Detailed changes in this PR
CommitmentStrategy
structs.CommitmentController
CommitmentService
for submitting commitments ifCommitmentController
advises to.sequencer.rs
intorunner.rs
for consistency with prover / full node.How it works
CommitmentService
CommitmentService
consults withCommitmentController
whether it should commit or not.CommitmentController
runs eachCommitmentStrategy
and takes whichever returnsCommitmentInfo
CommitmentService
submits commitment if advised to do so.One more thing to pay attention to, is that the
StateDiffThreshold
commitment strategy now usesbrotli
for compressing the state diff before deciding on the threshold. This is a CPU heavy operation which should run in it's own task.Linked Issues